sdk: Fix walk_submodel() skipping Entity and Operation children#465
Merged
s-heppner merged 3 commits intoApr 21, 2026
Merged
Conversation
Fixes eclipse-basyx#423. The traversal now recurses into Entity.statement and Operation.input_variable/output_variable/in_output_variable, so File SubmodelElements nested inside these containers are no longer silently dropped when reading AASX files. Adds test_traversal.py with 13 unit tests covering the fix and regression cases.
s-heppner
requested changes
Mar 6, 2026
- Extract public walk_submodel_element() helper that yields all descendants of a given SubmodelElement (but not the element itself), replacing the private module-level _walk_submodel_helper() - Narrow walk_submodel() signature to accept only Submodel - Update tests: use assertCountEqual (order-agnostic), rename post_order test methods, and use walk_submodel_element where applicable
s-heppner
reviewed
Apr 21, 2026
s-heppner
left a comment
s-heppner
left a comment
Member
There was a problem hiding this comment.
Please fix the failing CI check. Other than that, this LGTM!
s-heppner
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #423.
traversal.walk_submodel()was only recursing intoSubmodelElementCollection.valueandSubmodelElementList.value, missing two other container types defined by the AAS specification:Entity.statementOperation.input_variable,Operation.output_variable,Operation.in_output_variableThis caused a concrete data-loss bug:
FileSubmodelElements nested inside anEntityorOperationwere silently dropped from thefile_storewhen reading AASX files(
AASXReader._collect_supplementary_filesuseswalk_submodelto find allFileelements).Changes
sdk/basyx/aas/util/traversal.py: Extracted element-level recursion into a private helper_walk_submodel_helper()that handles all four container types. The post-order traversal(children before parent) is preserved and works correctly for arbitrary nesting
(e.g.
EntityinsideOperation.input_variable,SubmodelElementCollectioninsideEntity.statement).sdk/test/util/test_traversal.py(new): 13 unit tests covering basic traversal,Entitystatements,
Operationvariables, nested combinations, empty containers, and two explicitregression tests for issue traversal.walksubmodel(): Child Submodel Elements of
EntityandOperationare skipped #423.